Metrics Span Multiplier #2172
Merged
Metrics Span Multiplier #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mapno
reviewed
Mar 6, 2023
altanozlu
requested review from
knylander-grafana,
joe-elliott,
annanay25,
mdisibio,
yvrhdn and
zalegrala
as code owners
|
Hi @mapno, do you have any idea why "Test Packages" test failed and can we rerun it ? |
Merged
mdisibio
pushed a commit
to mdisibio/tempo
that referenced
this pull request
Apr 18, 2023
* add config * add GetSpanMultiplier * add tests & fix tests * fmt * make it span_multiplier_key & add examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds span multiplier feature by using "X-SampleRatio" attribute.
Which issue(s) this PR fixes:
Fixes #2166
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]