Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vParquet2] all commits for vParquet2 as changes of the existing vParquet #2243

Closed
wants to merge 8 commits into from

Conversation

stoewer
Copy link
Contributor

@stoewer stoewer commented Mar 21, 2023

What this PR does:

This pull request contains all commits for vParquet2 as changes of the existing vParquet. The purpose of this PR is to make it easier for reviewers to see what has changed between the two versions.

Important: Do not merge!

stoewer added 8 commits March 21, 2023 16:09
Make column names using timestamps more consistent and more similar the
names used by OTEL
Rename columns to match the latest OTEL standard
Increases performance of queries for span duration, as it is no longer
required to search two columns to get the span duration
The columns are a prerequisite to improve structural TraceQL queries.
The new columns are not populated yet
This makes the schema more similar to the OTEL standard and makes it
possible to add a numeric span ID later (see ParentID vs ParentSpanID)
This improves the compatibility with other tooling using the parquet
format such as parquet-mr/parquet-cli
@stoewer stoewer force-pushed the vparquet2-main-in-tree branch from f488263 to 1d03b23 Compare March 21, 2023 06:09
@stoewer stoewer closed this Apr 5, 2023
@stoewer stoewer deleted the vparquet2-main-in-tree branch April 28, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant