FIX-2167: tempodb integer divide by zero error

[mghildiy]

What this PR does:
This PR solves the 'divison by zero' error occurring during compaction.

Which issue(s) this PR fixes:
Fixes #2167

Checklist

• [ config_test, tempodb_test] Tests updated
• Documentation added
• CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

[CLAassistant]

All committers have signed the CLA.

[joe-elliott]

thanks for submitting a fix for this! i think you need to rebase on top of main or merge main to get up to date. that should resolve your go.mod issues.

[mghildiy]

I merged main into my feature branch, and it somehow stopped git working. For every git command I now get:

fatal: not a git repository (or any of the parent directories): .git

Never faced it with git. Anyone having any idea?

PS: Seems it got corrupted, so I cloned once again. Please ignore this comment.

[mghildiy]

I have made the recommended changes. Pleade have a look.

• A new validation method for CompactorConfig in config.go to check that compaction range is not 0
• Corresponding test in config_test.go.
• Call this new method in EnableCompaction method in tempodb.go, and if it returns error, just return from the method without doing anything more.
• Corresponding test in tempodb_test.go

[joe-elliott]

nice, thanks for restructuring. This PR is looking a lot cleaner now. Please clean up the changelog conflict and consider the small comments I've made and then we can merge.

[joe-elliott]

Nice fix! Thanks

[mghildiy]

Hmmm....I am a bit surprised as I saw a test failure. And when I ran that test(TestInstance_cantWriteToWAL) locally, there too it failed. But now PR is approved.