-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli list blocks usability improvements #403
Conversation
…s specified. When flag specified then inlude compacted y/n column. Sort by block end time and add age column.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added copy-edit suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I like the simplistic implementation of the boundedWaitGroup. :)
Let's also add to the changelog as its a user facing change.
Credit goes to a different author. Was looking around for popular solutions to the limited concurrency and came across it via: /r/golang comment and playground |
Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc and code comments look good. Just a couple more copy -edit request.
What this PR does:
A few minor usability improvements to the
list blocks
command:--include-compacted
flag is specified (and show new flag column in results)Which issue(s) this PR fixes:
n/a
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]