Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Update statement for metrics-generator for Cloud #4151

Conversation

knylander-grafana
Copy link
Contributor

@knylander-grafana knylander-grafana commented Oct 2, 2024

What this PR does:

Addresses a customer issue that it wasn't clear that you can enable Metrics Generator for Grafana Cloud in Application Observability.

Original PR update: #4141

This PR:

  • Cleans up the copied-from-cloud admonition notes
  • Removes references to Cloud metrics-generator vs OSS in the Tempo docs
  • Instead, points readers to the Grafana Cloud Traces documentation for metrics-generator

Which issue(s) this PR fixes:
Fixes https://github.com/grafana/support-escalations/issues/12501
Fixes https://github.com/grafana/support-escalations/issues/11695

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor

github-actions bot commented Oct 2, 2024

This PR must be merged before a backport PR will be created.

Copy link
Member

@yvrhdn yvrhdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linking to grafana-cloud docs makes sense to me 👍

docs/sources/tempo/metrics-generator/span_metrics.md Outdated Show resolved Hide resolved
Co-authored-by: Yuna Verheyden <yuna.verheyden@posteo.net>
@knylander-grafana
Copy link
Contributor Author

Thank you for the review!

@knylander-grafana knylander-grafana merged commit 6951cf6 into grafana:main Oct 7, 2024
17 checks passed
@knylander-grafana knylander-grafana deleted the update-metrics-gen-cloud-note branch October 7, 2024 22:50
github-actions bot pushed a commit that referenced this pull request Oct 7, 2024
* Update statement for metrics-generator for Cloud

* Fix alias

* Update docs/sources/tempo/metrics-generator/span_metrics.md

Co-authored-by: Yuna Verheyden <yuna.verheyden@posteo.net>

---------

Co-authored-by: Yuna Verheyden <yuna.verheyden@posteo.net>
(cherry picked from commit 6951cf6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-v2.6 type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants