Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use slices and map from the go stdlib instead of golang.org/x/exp #4152

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

dastrobu
Copy link
Contributor

@dastrobu dastrobu commented Oct 2, 2024

What this PR does:

use slices and map from the go stdlib instead of golang.org/x/exp

Which issue(s) this PR fixes:

nil

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@dastrobu
Copy link
Contributor Author

dastrobu commented Oct 2, 2024

As we have go 1.23 now, I guess it would be nice to prefer the stdlib over golang/x/exp for maps and slices.

I did not add this to the CHANGELOG yet, as I am not sure if you want this kind of cleanup mentioned there.

Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup. Looking for your thoughts on a small perf improvement.

modules/overrides/runtime_config_overrides.go Outdated Show resolved Hide resolved
Signed-off-by: Daniel Strobusch <1847260+dastrobu@users.noreply.github.com>
Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joe-elliott joe-elliott merged commit f3433c6 into grafana:main Oct 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants