[DOC] Remove the traceQLStreaming feature flag #4173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knylander-grafana
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
yvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
knylander-grafana
changed the title
3 tasks
javiermolinar
approved these changes
Oct 11, 2024
|
You're welcome! Thank you for the review. :) |
Signed-off-by: Joe Elliott <number101010@gmail.com>
…grafana#4163) * Dynamic reordering of binop branches * consts and cleanup * changelog
) * add local pprof files in .gitignore * fast distinct_string_collector * faster scoped_distinct_string collector * Update the usage of the combiners * add a benchmark for duplicates * Add benchmarks * Update CHANGELOG.md * return error on calls to Diff with diff disabled * return exceeded bool on Collect in ScopedDistinctString * test collect return and Exceeded * Add a note about DistinctString collector's Collect return bool * only new in withDiff versions * remove extra note * move the lock down in the Diff method * fix flaky test
The query frontend treats all jobs as the same size when it farms them out to the queriers. This can cause querier instability b/c some jobs actually require quite a bit more resources to execute. By assigning weights to jobs we can reduce the amount each querier is asked to do will hopefully: reduce querier OOMs/timeouts/retries reduce querier latency increase total throughput Other changes Removed the roundtripper httpgrpc bridge and pushed the concept of pipeline.Request all the way down into the cortex frontend code. This can be a nice perf improvement b/c translating http -> httpgrpc is costly and we are pushing it to the last moment. Currently for some queries we are translating thousands of jobs and then throwing them away. Removed redundant parseQuery and createFetchSpansRequest to consolidate on the Compile function in pkg/traceql Check for context error before going through retry logic in retryWare. This causes retry metrics to be more accurate in the event of many cancelled jobs.
…a#4119) * Pushdown collection of results from generators in the querier * Update CHANGELOG.md
|
Okay, i have no idea what happened in this PR. There should only be some minor changes to one or two files, not 53 files changed. Redo: #4188 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Removes the traceQLStreaming feature flag, per grafana/grafana#94528
Which issue(s) this PR fixes:
Part of grafana/grafana#94528
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]