Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add range condition to bytes predicates #4198

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Conversation

ie-pham
Copy link
Contributor

@ie-pham ie-pham commented Oct 16, 2024

What this PR does: Remove earlier comment to add range condition to byte predicates.

                                                                     │ before-onlyid.txt │           after-onlyid.txt           │
                                                                     │      sec/op       │    sec/op     vs base                │
BackendBlockTraceQL/trace:id_=_`xxx`-16        17.421m ± 3%   9.895m ± 13%  -43.20% (p=0.000 n=20)

                                                                     │ before-onlyid.txt │           after-onlyid.txt            │
                                                                     │        B/s        │      B/s       vs base                │
BackendBlockTraceQL/trace:id_=_`xxx`-16        540.3Mi ± 3%   837.7Mi ± 11%  +55.03% (p=0.000 n=20)

                                                                     │ before-onlyid.txt │          after-onlyid.txt          │
                                                                     │     MB_io/op      │  MB_io/op   vs base                │
BackendBlockTraceQL/trace:id_=_`xxx`-16          9.870 ± 0%   8.691 ± 0%  -11.95% (p=0.000 n=20)

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@ie-pham ie-pham enabled auto-merge (squash) October 16, 2024 18:23
@ie-pham ie-pham merged commit 891e6bb into grafana:main Oct 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants