-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: skip exemplars for instant queries #4204
fix: skip exemplars for instant queries #4204
Conversation
Can we live without this config? tempo/modules/frontend/config.go Line 96 in 280128f
If |
This sounds good to me. @mapno You originally implemented this, can you think of a scenario where max_exemplars=0 and exemplars=true is meaningful? |
Co-authored-by: Martin Disibio <mdisibio@gmail.com>
Can't think of one. Possible was left from a previous implementation. I'm good to remove it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating the docs. The updates look good.
fix: skip exemplars for instant queries (#4204) Currently, we are computing the exemplars for query_range and instant queries. Since exemplars are not supported for instant queries (same as Prometheus) we can save that computing time. It also fixes a bug where the exemplars query param was not being honored Co-authored-by: Martin Disibio <mdisibio@gmail.com>
What this PR does:
Currently, we are computing the exemplars for
query_range
andinstant queries
. Since exemplars are not supported for instant queries (same as Prometheus) we can save that computing time.It also fix a bug where the
exemplars
query param was not being honoredChecklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]