Metrics Generator: Max limit on number of failed flushes #4254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
mdisibio,
mapno,
zalegrala,
electron0zero,
ie-pham,
stoewer and
javiermolinar
as code owners
Signed-off-by: Joe Elliott <number101010@gmail.com>
javiermolinar
approved these changes
Oct 31, 2024
| go func() { | ||
| time.Sleep(delay) | ||
| if _, err := p.flushqueue.Enqueue(op); err != nil { | ||
| _ = level.Error(p.logger).Log("msg", "failed to requeue block for flushing", "err", err) |
There was a problem hiding this comment.
What happens if we fail to requeue? Should we delete the block as well?
There was a problem hiding this comment.
i think no. the only time enqueue can fail is if the queue is stopped:
https://github.com/grafana/tempo/blob/main/pkg/flushqueues/priority_queue.go#L91-L93
in this case the process is shutting down and so we want to keep the block for when it starts back up. we could definitely be more explicit about this tho.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Institutes a very generous limit of 100 on failed flush attempts as well as a metric to help track this. This prevents constant retries on blocks that cannot be flushed due to corruption.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]