Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traces Cleanup #4260

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Traces Cleanup #4260

merged 2 commits into from
Nov 1, 2024

Conversation

joe-elliott
Copy link
Member

What this PR does:
I set out to clean up our traces and remove all orphaned spans, but there were fewer than expected. Our query path is entirely connected.

  • Connected some local block operations in the generator.
  • Similar fix in the ingester and also updated log lines to use "tenant" over "userID" which is preferred.
    image
  • Gave context to some orphanned s3.Reads in usage stats
    image
  • Connected some orphanned spans in our polling cycle

There are still two orphanned spans I can't figure out how to fix related to ring management. They create single span "CAS" and "GET" traces. I'll let the next person figure those out :).

https://github.com/grafana/dskit/blob/a4a4dca2b2e64cc70a1a719c5f3dbf7a5c81adba/kv/metrics.go#L97
https://github.com/grafana/dskit/blob/a4a4dca2b2e64cc70a1a719c5f3dbf7a5c81adba/kv/metrics.go#L81

There are also a fair number of "low value" traces. These are auto instrumented by our http server and may be best removed through sampling techniques. Things like getting metrics or health checks.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Copy link
Contributor

@zalegrala zalegrala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup.

@joe-elliott joe-elliott merged commit 013a4ee into grafana:main Nov 1, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants