Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
I set out to clean up our traces and remove all orphaned spans, but there were fewer than expected. Our query path is entirely connected.
There are still two orphanned spans I can't figure out how to fix related to ring management. They create single span "CAS" and "GET" traces. I'll let the next person figure those out :).
https://github.com/grafana/dskit/blob/a4a4dca2b2e64cc70a1a719c5f3dbf7a5c81adba/kv/metrics.go#L97
https://github.com/grafana/dskit/blob/a4a4dca2b2e64cc70a1a719c5f3dbf7a5c81adba/kv/metrics.go#L81
There are also a fair number of "low value" traces. These are auto instrumented by our http server and may be best removed through sampling techniques. Things like getting metrics or health checks.
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]