-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Update tempo-distributed helm chart doc #4370
Merged
knylander-grafana
merged 4 commits into
grafana:main
from
knylander-grafana:4326-helm-chart-doc-update
Nov 26, 2024
Merged
[DOC] Update tempo-distributed helm chart doc #4370
knylander-grafana
merged 4 commits into
grafana:main
from
knylander-grafana:4326-helm-chart-doc-update
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knylander-grafana
requested review from
joe-elliott,
mdisibio,
mapno,
yvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
November 23, 2024 03:14
docs/sources/helm-charts/tempo-distributed/get-started-helm-charts/_index.md
Outdated
Show resolved
Hide resolved
ie-pham
approved these changes
Nov 25, 2024
docs/sources/helm-charts/tempo-distributed/get-started-helm-charts/_index.md
Outdated
Show resolved
Hide resolved
ayah-el
requested changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggested fixes
docs/sources/helm-charts/tempo-distributed/get-started-helm-charts/_index.md
Outdated
Show resolved
Hide resolved
docs/sources/helm-charts/tempo-distributed/get-started-helm-charts/_index.md
Outdated
Show resolved
Hide resolved
docs/sources/helm-charts/tempo-distributed/get-started-helm-charts/_index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Ayah Elshaikh <150149197+ayah-el@users.noreply.github.com>
Done. would you review again? |
ayah-el
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Update Helm chart procedures for accuracy.
New: Large configuration files examples are now collapsed using the collapse shortcode.
Which issue(s) this PR fixes:
Fixes these issues in #4326
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]