Fix object prefix not being stripped for Dell ECS #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensure that the same object prefix string is used to query and strip an object when listing all the objects in a bucket. Some S3 implementations (in this case Dell ECS) cannot be relied upon to return the correct `res.Prefix`. Dell ECS will return it URLencoded, e.g. "traceID%2F" instead of "traceID/".
|
|
|
Hi thanks for taking care of this! It's looking good for S3 and MinIO. If you can confirm it fixes Dell ECS then we'll merge. |
|
Awesome, thanks, I am getting it built and tested today, got distracted on Friday. |
greed42
reviewed
Mar 1, 2021
Co-authored-by: Graham Reed <greed@7deadly.org>
greed42
approved these changes
Mar 1, 2021
kradalby
requested review from
dgzlopes,
joe-elliott and
mdisibio
as code owners
|
I can confirm that it works with Dell ECS, I have played around with it today, read, find, compact, write cycles seem to work as intended, there are no longer any errors thrown in the log. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This commit ensure that the same object prefix string is used to query and strip
an object when listing all the objects in a bucket.
Some S3 implementations (in this case Dell ECS) cannot be relied upon to return
the correct
res.Prefix. Dell ECS will return it URLencoded, e.g. "traceID%2F"instead of "traceID/".
I am able to test this on ECS, but I do not have access to other blob storage, so help with testing additional storage backend would be appreciated.
Which issue(s) this PR fixes:
Fixes #558
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]