-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add span deduper to support zipkin client/server kind spans #687
Conversation
Signed-off-by: Annanay <annanayagarwal@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments but otherwise looks good so far. Besides the comments two other things that would be nice to see:
- a comment to indicate that this is being done to support zipkin
- benchmarking of various trace sizes: 100, 1k, 10k, 100k spans
I'm a little nervous about the impact on correctness but with @kvrhdn 's improvements to the vulture I think we will feel better.
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Just need to add benchmarks now. |
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments. I think you need to make a change to your benchmark but I don't expect it to appreciably change the results.
Agree if the results stay roughly the same that we can just always run the deduper.
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Testing:
Signed-off-by: Annanay annanayagarwal@gmail.com
Benchmark results
I think these are ok to proceed.
What this PR does:
Adds a span deduper middleware that allows multiple spans of the same ID but different spanKind (client/server).
This is supported in Zipkin.
Which issue(s) this PR fixes:
Fixes #682
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]