Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to GCS driver and Query Path #693

Merged
merged 7 commits into from
May 13, 2021

Conversation

annanay25
Copy link
Contributor

@annanay25 annanay25 commented May 12, 2021

What this PR does:
Bunch of small improvements:

  • replace the use of ioutil.ReadAll() with ReadAllWithEstimate with a predefined buffer size, using the returned object attributes in tempodb/backend/gcs and tempodb/backend/s3
  • add ContentLength header in span id deduper middleware
  • update gcs driver version from v1.12.0 => v1.15.0. Primarily to catch the following change
// configureHTTP2 configures the ReadIdleTimeout HTTP/2 option for the
// transport. This allows broken idle connections to be pruned more quickly,
// preventing the client from attempting to re-use connections that will no
// longer work.
  • fix a panic in query frontend by checking for nil response

Which issue(s) this PR fixes:
Fixes #na

Checklist

  • Tests updated
  • NA Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

annanay25 added 5 commits May 11, 2021 18:34
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
modules/frontend/frontend.go Show resolved Hide resolved
tempodb/backend/gcs/gcs.go Outdated Show resolved Hide resolved
annanay25 added 2 commits May 13, 2021 13:44
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
@annanay25 annanay25 merged commit 0a5eb28 into grafana:main May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants