-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare CI for our internal release train #828
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I guess @kvrhdn can give the signoff on this one since he has been working with you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙂 I just have some minor questions.
This requires bash to be installed in the alpine/git image docker run --rm -it --entrypoint /bin/sh alpine/git /git # bash /bin/sh: bash: not found /git # apk --update --no-cache add bash fetch https://dl-cdn.alpinelinux.org/alpine/v3.13/main/x86_64/APKINDEX.tar.gz fetch https://dl-cdn.alpinelinux.org/alpine/v3.13/community/x86_64/APKINDEX.tar.gz (1/2) Installing readline (8.1.0-r0) (2/2) Installing bash (5.1.0-r0) Executing bash-5.1.0-r0.post-install Executing busybox-1.32.1-r6.trigger OK: 27 MiB in 33 packages /git # ^C
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the edits 🙂 This is looking good, can someone with the necessary permission merge this for us? @annanay25 maybe?
This PR lays the groundwork to adopt an internal weekly release cycle. This simply adds an additional trigger to CI so it can build and push artifacts on
r?
andr??
branches, which are later consumed by our internal automation.