Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include distributed docker-compose example #859

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Conversation

zalegrala
Copy link
Contributor

@zalegrala zalegrala commented Aug 9, 2021

Without this change, there is not an example of how a user might proceed with
local testing and development using docker-compose. Here we copy the local
docker-compose example and extend it to include the distributed configuration
pieces necessary to get a functional example.

Fixes #746

Checklist

  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor

@annanay25 annanay25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @zalegrala! Added a few comments.

@zalegrala zalegrala force-pushed the dockerComposeDistributed branch from 3c379c2 to c185805 Compare August 10, 2021 13:45
@zalegrala zalegrala marked this pull request as ready for review August 10, 2021 13:49
@zalegrala zalegrala force-pushed the dockerComposeDistributed branch from c185805 to 0e5d2e5 Compare August 10, 2021 13:50
@zalegrala
Copy link
Contributor Author

Thanks for the review! I believe I addressed the comments, except for the distributed dashboards testing.

Copy link
Member

@yvrhdn yvrhdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed we are missing the compactor 😳
The compactor is a required component to run Tempo long-term: https://grafana.com/docs/tempo/latest/operations/architecture/

And I querying the local backend doesn't seem to work well. I can successfully query a trace ID for about 10 minutes and then I get "trace not found". So I believe this matches with when the ingesters flush their blocks to the backend.
As long as the block lives on the ingester, the querier can query the ingesters to find the trace. But once the block is flushed and deleted, the querier has to find it in the backend. I guess something is going wrong while flushing...

@zalegrala zalegrala force-pushed the dockerComposeDistributed branch from 0e5d2e5 to fbb3fe2 Compare August 10, 2021 16:47
CHANGELOG.md Outdated Show resolved Hide resolved
@zalegrala zalegrala force-pushed the dockerComposeDistributed branch from fbb3fe2 to 3077f05 Compare August 10, 2021 19:18
@zalegrala zalegrala force-pushed the dockerComposeDistributed branch 3 times, most recently from 1341bf9 to 681162f Compare August 11, 2021 20:08
@zalegrala
Copy link
Contributor Author

Thanks for the review. This is looking pretty stable now that minio is in use.

@zalegrala zalegrala force-pushed the dockerComposeDistributed branch 3 times, most recently from c56327e to ca78b94 Compare August 12, 2021 20:07
Copy link
Contributor

@annanay25 annanay25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work @zalegrala 🚀

Copy link
Member

@yvrhdn yvrhdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂 Just some small details left to straighten out. The example works as expected and it's a welcome addition!

example/docker-compose/distributed/readme.md Outdated Show resolved Hide resolved
example/docker-compose/distributed/readme.md Outdated Show resolved Hide resolved
@zalegrala zalegrala force-pushed the dockerComposeDistributed branch from ca78b94 to 812c7e2 Compare August 13, 2021 13:12
@zalegrala zalegrala force-pushed the dockerComposeDistributed branch from 812c7e2 to e967924 Compare August 13, 2021 13:42
Without this change, there is not an example of how a user might proceed with
local testing and development using docker-compose.  Here we copy the local
docker-compose example and extend it to include the distributed configuration
pieces necessary to get a functional example.
@zalegrala zalegrala force-pushed the dockerComposeDistributed branch from e967924 to 8a60c77 Compare August 16, 2021 16:10
Copy link
Member

@yvrhdn yvrhdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work. This will be very useful 🙂

@yvrhdn yvrhdn merged commit 3f41068 into main Aug 16, 2021
@yvrhdn yvrhdn deleted the dockerComposeDistributed branch August 16, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a tempo-distributed docker-compose
5 participants