-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Make s3 backend readError logic more robust #905
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for the contribution. Is there any difference between the current check err.Error() == s3KeyDoesNotExist
and checking the error code for the same 'no key' error? It's being checked in both modified methods.
Sorry, I re-read your description and saw the explanation |
I think it is make sense to just check the code. |
@mapno I've changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice!
It seems need approved for run CI. |
Thanks for the contribution, wei. We will wait til we cut 1.1 to merge. |
Got it, thx |
for some s3 compatible storage backend, it may has differnt error messsage when object not exist.
I think using minio.error code for judge the object is not exist is more robust.