add configurable 'job_selectors' and 'cluster_selectors' #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinschoonover
requested review from
annanay25,
dgzlopes,
joe-elliott,
yvrhdn,
mapno and
mdisibio
as code owners
|
|
annanay25
reviewed
Sep 6, 2021
There was a problem hiding this comment.
Thanks for the contribution @kevinschoonover. Long overdue refactoring of the jsonnet. This is mostly good to go, just have some minor comments.
kevinschoonover
force-pushed
the
main
branch
from
f2200f2 to
f2ae32b
Compare
Replaces hard-coded usage of [namespace, job] or [namespace, cluster] in alerts and recording rules to support different configurations of cluster and job unique identifier labels
kevinschoonover
force-pushed
the
main
branch
from
f2ae32b to
118ea68
Compare
kevinschoonover
changed the title
|
@annanay25 Thanks for the fast review! All the comments should be addressed. Let me know if I missed something or you have any other changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Similiar to grafana/cortex-jsonnet#319 in cortex, Replaces hard-coded usage of [namespace, job] or [namespace, cluster] in alerts and recording rules to support different configurations of cluster and job unique identifier labels.
I generated the existing alerts/rules in
yamls/folder and the only differences I see are recent changes toyamls/alerts.ymlthat haven't been syncedWhich issue(s) this PR fixes:
N/A
Checklist
- [ ] Tests updated- [ ] Documentation addedCHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]