Change user lists to sets

[medains]

Users as lists may not be reported back from grafana in the same order - resulting in continually reported resource changes.

Treating the users as sets instead deals with this nicely.

[trotttrotttrott]

Thanks, @medains. I agree with this change, but it breaks some acceptances tests because we can't read elements from sets as the tests are trying to do. Could you please update them? Removing the following should do it:

• terraform-provider-grafana/grafana/resource_organization_test.go

  Lines 65 to 67 in 71990e2

  	resource.TestCheckResourceAttr(
  	"grafana_organization.test", "admins.0", "john.doe@example.com",
  	),

• terraform-provider-grafana/grafana/resource_organization_test.go

  Lines 89 to 91 in 71990e2

  	resource.TestCheckResourceAttr(
  	"grafana_organization.test", "editors.0", "john.doe@example.com",
  	),

• terraform-provider-grafana/grafana/resource_organization_test.go

  Lines 140 to 142 in 71990e2

  	resource.TestCheckResourceAttr(
  	"grafana_organization.test", "admins.0", "john.doe@example.com",
  	),

• terraform-provider-grafana/grafana/resource_organization_test.go

  Lines 164 to 169 in 71990e2

  	resource.TestCheckResourceAttr(
  	"grafana_organization.test", "admins.0", "admin@localhost",
  	),
  	resource.TestCheckResourceAttr(
  	"grafana_organization.test", "admins.1", "john.doe@example.com",
  	),

Also please remove the following from the organization resource docs:

Note - Users specified for each role-group (admins, editors, viewers) should be listed in ascending alphabetical order (A-Z). By defining users in alphabetical order, Terraform is prevented from detecting unnecessary changes when comparing the list of defined users in the resource to the (ordered) list returned by the Grafana API.

[medains]

Updated as requested

[trotttrotttrott]

Awesome. Thanks, @medains 👍