Adding team resource functionality #120
Conversation
|
Hi @jonathan-dorsey, this looks great. Since you opened this, the api client got switched to https://github.com/grafana/grafana-api-golang-client so we can have folks in the |
@trotttrotttrott - thanks for the update! I opened a new PR for the grafana project. Let me know if there is anything else you would like me to change/add. |
|
@trotttrotttrott - PR is ready for review. I updated the project to use the new version of the go api that includes my changes for the team ID. |
|
@trotttrotttrott - commands run. Let me know if you need anything else. Thanks! |
There was a problem hiding this comment.
@jonathan-dorsey I found a few more things that need attention. Apologies for the back and forth.
|
@trotttrotttrott - no worries! I appreciate the feedback and these are all good changes. A lot of these were just bad changes I furthered by copying from the org code. I am almost ready to start using the provider to manage a new Grafana instance. During that process I will do a lot more testing of edge scenarios and enter new defects for the org code as well. I would like to add some tests for some of those 404/409 errors, but I think it would require either applying changes to Grafana outside of terraform or manipulating the terraform state within the test and I'm not sure how to do either without some more research. At any rate - changes have been incorporated and should be ready for another review. Thanks again! |
This pull request adds team and team member functionality to the provider. Note: This code won't work until the PR nytm/go-grafana-api#64 is incorporated into the Grafana go api. We need the team id to be returned to the provider when a team is added.