Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Targets/Docs for Releases and Changelog Generation #127

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

trotttrotttrott
Copy link
Member

Adds changelog and release targets to remove some manual steps in the release process.

The changelog is generated with github-changelog-generator. This gist is a preview of the output. The generation and committing of the changelog should likely move to CI as a followup.

Copy link
Contributor

@jvrplmlmn jvrplmlmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


The Action creates the release, but leaves it in "draft" state. Open it up in a
[browser](https://github.com/grafana/terraform-provider-grafana/releases) and if
all looks well, mash the publish button.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if mash is a typo (you mean smash?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mash was what I was going for, but perhaps a bit crude. I think it's most often used to describe how some folks play arcade-style video games by frantically and repeatedly pressing every button at the same time because they have no idea what they're doing 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

Ah you mean playing Eddie in Tekken

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES! Exactly 😂

@trotttrotttrott trotttrotttrott merged commit 10b8c13 into master Oct 16, 2020
@trotttrotttrott trotttrotttrott deleted the chnagelog-generator branch October 16, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants