Add team preferences functionality to provider #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add team preferences functionality
|
NOTE: This PR cannot be merged until https://github.com/grafana/grafana-api-golang-client/pull/11/files is merged for the Go API. The call to update the preferences was incorrect and needed to be fixed. Once that PR is merged I will update the version of the api being referenced and call the "go mod vendor" and push those changes. |
|
@trotttrotttrott - I believe this PR is ready for review now. Thanks! |
Co-authored-by: Chris Trott <908409+trotttrotttrott@users.noreply.github.com>
|
@trotttrotttrott - comments incorporated. Thanks! |
trotttrotttrott
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will add the ability to maintain team preferences in the Grafana provider. The largest driver for this change is to be able to specify a home dashboard for each team. This PR is similar in structure to the PR that added folder permissions. Since team preferences cannot be added or deleted, we always perform an update. The delete will simply attempt to use the system default values, but if the corresponding team has already been deleted we simply ignore the error and continue.