Add full Stackdriver data source support #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanaross
changed the title
trotttrotttrott
approved these changes
Jan 22, 2021
There was a problem hiding this comment.
Looks good @ryanaross. Thanks for tracking this for so long 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds 4 new fields to JsonData in the data source management.
Why
Closes issue #105 . As the issue states, the Cloud Monitoring/Stackdriver data source needs more fields in the jsonData portion in order to be configured and work.
Grafana Documentation:
https://grafana.com/docs/grafana/latest/datasources/cloudmonitoring/#configure-the-data-source-with-provisioning
Verification
make testsucceeds. I also compiled usingmake build, and used the new binary to create a new Stackdriver data source successfully in a local Grafana instance.