Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2075-terraform #1770

Closed
wants to merge 4 commits into from
Closed

2075-terraform #1770

wants to merge 4 commits into from

Conversation

JohnnyK-Grafana
Copy link

@JohnnyK-Grafana JohnnyK-Grafana commented Aug 16, 2024

@JohnnyK-Grafana JohnnyK-Grafana requested a review from a team as a code owner August 16, 2024 17:39
@CLAassistant
Copy link

CLAassistant commented Aug 16, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

Copy link
Contributor

@ellisda ellisda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not that my approval is of any value here)

@JohnnyK-Grafana JohnnyK-Grafana enabled auto-merge (squash) September 26, 2024 16:12
@JohnnyK-Grafana
Copy link
Author

hey @jdbaldry - could you take a peek at this and let me know where things went rotten? thanks!

@jdbaldry
Copy link
Member

I can dig into this but it's probably best for a repository maintainer as they have the context for how the tests behave.

@jdbaldry
Copy link
Member

jdbaldry commented Sep 27, 2024

To help, you may want to provide more context in your PR subject and description to explain the purpose of the change so that can be compared to the patch that achieves that purpose

auto-merge was automatically disabled October 30, 2024 10:40

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants