Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data_source: make URL field optional #18

Merged
merged 3 commits into from
Apr 16, 2018
Merged

data_source: make URL field optional #18

merged 3 commits into from
Apr 16, 2018

Conversation

pearkes
Copy link
Contributor

@pearkes pearkes commented Mar 24, 2018

The CloudWatch datasource does not require the URL attribute via the API. This fixes #13.

With the changes cherry-picked from #17 tests pass.

$ make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v  -timeout 120m
?   	github.com/terraform-providers/terraform-provider-grafana	[no test files]
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccAlertNotification_basic
--- PASS: TestAccAlertNotification_basic (0.62s)
=== RUN   TestAccDashboard_basic
--- PASS: TestAccDashboard_basic (0.42s)
=== RUN   TestAccDashboard_disappear
--- PASS: TestAccDashboard_disappear (0.36s)
=== RUN   TestAccDataSource_basic
--- PASS: TestAccDataSource_basic (0.74s)
PASS
ok  	github.com/terraform-providers/terraform-provider-grafana/grafana	(cached)

The CloudWatch datasource does not require the URL attribute via
the API. This fixes #13.
This should fix #4 which is already mostly done.
@pearkes pearkes requested a review from a team April 4, 2018 15:45
@pearkes pearkes merged commit bea53ef into master Apr 16, 2018
@pearkes pearkes deleted the url-optional branch April 16, 2018 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make url field optional for grafana_data_source to support Cloudwatch
2 participants