Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CloudWatch metrics services documentation link #2029

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

fix: CloudWatch metrics services documentation link #2029

wants to merge 18 commits into from
+38 −38

Conversation

the-noob
Copy link

No description provided.

@the-noob the-noob requested review from a team as code owners February 11, 2025 23:58
@CLAassistant
Copy link

CLAassistant commented Feb 11, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@the-noob the-noob requested a review from a team as a code owner February 12, 2025 13:24
@the-noob
Copy link
Author

@andriikushch I've noticed 2 more links failing (https://github.com/grafana/terraform-provider-grafana/actions/runs/13274879797/job/37080145314?pr=2029) and replaced those too

andriikushch
andriikushch requested changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@andriikushch andriikushch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @the-noob, for updating this 👍

It looks good so far.

I checked the PR once again and left a few suggestions.

docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
templates/index.md.tmpl Outdated Show resolved Hide resolved
templates/index.md.tmpl Outdated Show resolved Hide resolved
templates/index.md.tmpl Outdated Show resolved Hide resolved
templates/index.md.tmpl Outdated Show resolved Hide resolved
the-noob and others added 9 commits February 13, 2025 17:27
@the-noob @andriikushch
Update docs/index.md
9142089 
Co-authored-by: andriikushch <andrii.kushch@gmail.com>
@the-noob @andriikushch
Update docs/index.md
3610830 
Co-authored-by: andriikushch <andrii.kushch@gmail.com>
@the-noob @andriikushch
Update docs/index.md
0ef4f8b 
Co-authored-by: andriikushch <andrii.kushch@gmail.com>
@the-noob @andriikushch
Update docs/index.md
af1eaef 
Co-authored-by: andriikushch <andrii.kushch@gmail.com>
@the-noob @andriikushch
Update templates/index.md.tmpl
1e78f7f 
Co-authored-by: andriikushch <andrii.kushch@gmail.com>
@the-noob @andriikushch
Update templates/index.md.tmpl
3de9b4a 
Co-authored-by: andriikushch <andrii.kushch@gmail.com>
@the-noob @andriikushch
Update templates/index.md.tmpl
fcbf9d7 
Co-authored-by: andriikushch <andrii.kushch@gmail.com>
@the-noob @andriikushch
Update templates/index.md.tmpl
d6ab389 
Co-authored-by: andriikushch <andrii.kushch@gmail.com>
@the-noob
Merge branch 'main' into fix-cloudwatch-metrics-services-link
becf419
andriikushch
andriikushch approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@andriikushch andriikushch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @the-noob!

Looks good to me! 👍

@the-noob
Copy link
Author

@andriikushch sorry but I'm a bit confused, anything else I need to do on my part ?

1 similar comment
@the-noob
Copy link
Author

@andriikushch sorry but I'm a bit confused, anything else I need to do on my part ?

@andriikushch
Copy link
Contributor

Hi @the-noob, I think your changes are good. Let me try to find out why the build is failing.

@andriikushch
Copy link
Contributor

Hi @grafana/platform-monitoring 👋 , could you please look at why the build is failing?

Thank you in advance!

@spinillos
Copy link
Member

Could you update your PR with main to see if the tests pass with the latest changes?

@the-noob
Copy link
Author

@spinillos done (I hope)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andriikushch andriikushch andriikushch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@the-noob @CLAassistant @andriikushch @spinillos