Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in grafana_dashboard_permission docs #211

Merged
merged 3 commits into from
Jun 9, 2021

Conversation

rssnyder
Copy link
Contributor

@rssnyder rssnyder commented Jun 9, 2021

self explanatory

╷
│ Error: Missing required argument
│ 
│   on main.tf line 20, in resource "grafana_dashboard_permission" "this":
│   20: resource "grafana_dashboard_permission" "this" {
│ 
│ The argument "dashboard_id" is required, but no definition was found.
╵
╷
│ Error: Unsupported argument
│ 
│   on main.tf line 21, in resource "grafana_dashboard_permission" "this":
│   21:   dashboard_uid = grafana_dashboard.this.dashboard_id
│ 
│ An argument named "dashboard_uid" is not expected here. Did you mean "dashboard_id"?
╵

Copy link
Member

@trotttrotttrott trotttrotttrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rssnyder! This file is actually generated from

dashboard_uid = grafana_dashboard.metrics.dashboard_id
. Running go generate would update this file from the example. There's some notes on how that works here. Would you mind updating the example file as well?

update in examples
@rssnyder
Copy link
Contributor Author

rssnyder commented Jun 9, 2021

@trotttrotttrott my bad, should have read through the entire readme, I reverted my change and updated the tf file in examples.

Copy link
Member

@trotttrotttrott trotttrotttrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, could you keep the change in both places?

examples/ is maintained manually, docs/ is generated by go generate which we manually run. It's confusing 😅

@rssnyder
Copy link
Contributor Author

rssnyder commented Jun 9, 2021

go generate

Ok sounds good. Did that.

Copy link
Member

@trotttrotttrott trotttrotttrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@trotttrotttrott trotttrotttrott merged commit 5956a73 into grafana:master Jun 9, 2021
@rssnyder rssnyder deleted the patch-1 branch June 9, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants