-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typo in grafana_dashboard_permission docs #211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rssnyder! This file is actually generated from
terraform-provider-grafana/examples/resources/grafana_dashboard_permission/resource.tf
Line 14 in 7517d8d
dashboard_uid = grafana_dashboard.metrics.dashboard_id |
go generate
would update this file from the example. There's some notes on how that works here. Would you mind updating the example file as well?
update in examples
@trotttrotttrott my bad, should have read through the entire readme, I reverted my change and updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, could you keep the change in both places?
examples/
is maintained manually, docs/
is generated by go generate
which we manually run. It's confusing 😅
Ok sounds good. Did that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
self explanatory