Synthetic Monitoring Resource Fixes #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that state is created consistently with the actual resources. The lat/lon float32/float64 conversion was making it appear as though changes were being made outside of Terraform.
Setting labels with an empty map was causing unexpected behavior between
null and {} values in state.
captncraig
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
latitudeandlongitude. The API wants afloat32butschema.TypeFloatonly supportsfloat64. The value for each will be different. Without calling read, the value was being stored differently on create than Terraform would expect on subsequent reads when creating execution plans. Calling the read function in create an update will always store thefloat64value in state.labelsasnullif none are set. Attempting to set it as an empty map was causing different behavior on create and read/update. Create set it tonullwhile the latter wanted it to be{}.