-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change of Library #27
Conversation
Hey @pearkes! |
@mlclmj without looking to closely it looks like they're still working on building it out based on the status. I'd imagine it might take some work to move to. It doesn't look like an extremely active library and without full coverage I'd be concerned it could impede work that people may want to do to this provider. If you maintain the SDK and have an ear to this community you may be in a position to support the provider better than the official SDK, though that is a little unintuitive. 😄 So I'd say given the information at hand we that this PR is the right approach for now. But I'm easy either way! |
Hey @pearkes, sorry for the delay getting back to you on this- I'm in agreement with you here, I think the library we now maintain would be the best option. We tried to rouse the folk maintaining the SDK to see whether it'd be a viable possibility so that there aren't two being clients developed in parallel, however we have yet to have any luck and I agree that it'd likely block continued work on this provider. I'm reopening this PR so that we can get this change finalized and continue development, thanks again for your help with this! |
Tests and vendor changes look good to me! Merging this. |
@tonglil @mlclmj are you two interested in getting commit access to this repo? Would be great to get your help maintaining and improving it. I'd happily facilitate that. See some background here: https://www.terraform.io/docs/extend/community/contributing.html. If so feel free to drop me an email: jack@hashicorp.com |
Hi!
Now that the library has been transferred to nytm/go-grafana-api and has been brought up to speed with the previously used repo, I have the following updates for the provider to finish this transition:
Closes #26