Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resource grafana_data_source #90

Merged
merged 7 commits into from
Jun 2, 2020
Merged

Update resource grafana_data_source #90

merged 7 commits into from
Jun 2, 2020

Conversation

mlclmj
Copy link
Contributor

@mlclmj mlclmj commented Apr 13, 2020

Summary

Makes long-overdue updates to the data source resource to introduce additional datasource types that can be fully configured with this provider including:

  • Elasticsearch
  • Graphite
  • OpenTSDB
  • Prometheus
  • MySQL
  • MSSQL
  • Postgres

This change also adds better testing for the types of datasources that can be added.

Details

  • Updated the upstream library to v0.3.1
  • Reordered schema fields into alphabetical order for readability/maintainability
  • Added table tests for the various data source types supported. Note that the Grafana API doesn't actually validate the presence of any of these fields or their values, however this is valuable in making sure that the upstream library is parsing and submitting values to Grafana as expected.
  • As part of this work, the access_key and secret_key fields of the secure_json_data block are now marked as optional rather than required. Previously this was in place as the only datasource type using the secret_json_data block was Cloudwatch, though this is no longer the case. This shouldn't result in a breaking change for anyone configuring Cloudwatch datasources through this provider.
  • Vendor folder was updated using go mod vendor

Resolves #22
Resolves #42

@ghost ghost added size/XXL labels Apr 13, 2020
@mlclmj
Copy link
Contributor Author

mlclmj commented Apr 18, 2020

Resolves #54

@mlclmj
Copy link
Contributor Author

mlclmj commented Apr 18, 2020

Resolves #68

Copy link
Contributor

@tonglil tonglil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice set of changes, LGTM

@moseskt
Copy link

moseskt commented Mar 9, 2021

@mlclmj any eta for full support for configuring Azure Monitor via terraform?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow skipping TLS verify in datasources expand json_data field usage.
3 participants