Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds clickthrough links mappable from data for circles #190

Closed
wants to merge 1 commit into from

Conversation

lha-wd
Copy link

@lha-wd lha-wd commented Apr 1, 2019

Hello everybody.

First of all great job on the panel.

I was missing the functionality of having a link for each of the generated circles based on the datasource-entries.

A textbox is now added, which can be used to specify the columnname (on table data) containing the link.

The link is then used to add an onclick listener to the circle.
I used code-fragments from PR #129 for this.

If the link is empty for some reason (for example: no link in datasource) the onclick listener will not be created.

I was only able to test it properly with MSSQL so any hints at problems with other datasources are welcomed.

With best regards,
Leo

@amotl
Copy link

amotl commented Apr 27, 2019

Dear @leonhardhaas,

thanks for sharing your work on this. While revisiting this topic from time to time, we just found your recent implementation based on top of #129, which was the most prominent candidate for us until now.

I was only able to test it properly with MSSQL so any hints at problems with other datasources are welcomed.

While we haven't run this yet, we are definitively looking forward. As we are running InfluxDB, we will report about our findings in this regard.

With kind regards,
Andreas.

amotl added a commit to grafana-toolbox/panodata-map-panel that referenced this pull request May 6, 2019
…a#190

Add basic variable interpolation based on keys from `dataPoint`.
Saying that, all metric values have been added to the dataPoint
beforehand by prefixing them with `point_` to allow for setting
things like `clickthroughURL: /url/to/$point_station_id` if
there’s a field called `station_id` in the current datapoint.
@amotl
Copy link

amotl commented May 11, 2019

Dear Leonhard,

we cherry-picked your improvements into our working branch at [1], wrote about this and further updates at [2] and just announced the outcome at [3], which you might also be interested in. Thanks a bunch for sharing your efforts.

With kind regards,
Andreas.

[1] https://github.com/hiveeyes/grafana-worldmap-panel
[2] https://community.grafana.com/t/giving-the-grafana-worldmap-panel-some-love/17210
[3] https://community.hiveeyes.org/t/grafana-worldmap-panel-0-3-0-dev-series/1824

@lha-wd
Copy link
Author

lha-wd commented May 15, 2019

Hello Andreas.

Thanks for the update and the consideration of adding my changes into your working branch.

With best regards,
Leo

@amotl
Copy link

amotl commented May 22, 2019

So, we might close this PR, right? I believe @fabienpomerol will be doing the same with #156. As @daniellee and others are pretty busy with other things, they probably will appreciate the community self-maintaining this ;].

However, he recognized the whole bunch of improvements already and might review them when he will find some time for that in order to bring the changes into mainline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants