Fix X-Ray Service Map filter trace list query #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fridgepoet
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Hey @jamesrwhite thanks so much for the contribution and your notes on the original issue!
To reproduce: I queried the Service Map, switched to Node Graph visualization, and chose a node and selected Traces > All.
I tested out the changes locally on:
- v8.4.7 - OK
- v8.5.1 - OK
- v9.4.0 - OK
- latest main v10.3.0-pre - OK
I was able to see the subtitle variable transform correctly.
Co-authored-by: Shirley <4163034+fridgepoet@users.noreply.github.com>
|
Hi again @jamesrwhite, I got some help from @idastambuk to write a test to describe what we're doing here. It's the last commit on another branch 3c0d131 |
|
@fridgepoet Absolutely, thanks for that. I've just merged that branch into this one 🚀 |
sarahzinger
approved these changes
Oct 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #153
I have tested it on Grafana
8.4.11and10.1.2.I tried to use the
NodeGraphDataFrameFieldNames.subTitleenum directly to generate the query but was struggling to get that to build correctly. If there's a better way to achieve this please point me in that direction and I'll happily change it, I'm aware this approach is pretty hacky 😅