Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stalebot for issues #226

Merged
merged 2 commits into from
Jun 5, 2024
Merged

add stalebot for issues #226

merged 2 commits into from
Jun 5, 2024

Conversation

katebrenner
Copy link
Contributor

@katebrenner katebrenner requested a review from a team as a code owner May 31, 2024 19:30
@katebrenner katebrenner requested review from iwysiu and njvrzm May 31, 2024 19:30
Copy link
Contributor

@iwysiu iwysiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may need to update plugin-e2e. It's not failing for the same reason, but I had the same test failing because I needed to update it https://raintank-corp.slack.com/archives/C01LVB0CYTW/p1716921025766539

@kevinwcyu
Copy link
Contributor

e2e tests are failing because there was a recent change to the multiselect component in @grafana/ui grafana/grafana#87906

The empty option in the columns dropdown is causing the panel to not show correct column.

Screenshot 2024-05-31 at 4 41 44 PM

Haven't looked at what the correct fix is yet though. I can take a look on Monday at how to fix this, but I think this PR can just be merged even with the failing e2e test

@njvrzm njvrzm removed their request for review June 5, 2024 09:04
@katebrenner katebrenner merged commit 8a4b598 into main Jun 5, 2024
7 checks passed
@katebrenner katebrenner deleted the stalebot branch June 5, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants