Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: use ReadAuthSettings to get authSettings #236

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

kevinwcyu
Copy link
Contributor

@kevinwcyu kevinwcyu commented Jun 26, 2024

Uses ReadAuthSettings which tries to read auth settings from context first and then automatically falls back to reading auth settings from the environment.

Added a comment in #234 to add this to the changelog in that PR

@kevinwcyu kevinwcyu marked this pull request as ready for review June 26, 2024 17:54
@kevinwcyu kevinwcyu requested a review from a team as a code owner June 26, 2024 17:54
@kevinwcyu kevinwcyu merged commit 5fdaab7 into main Jun 26, 2024
8 checks passed
@kevinwcyu kevinwcyu deleted the kevinwcyu/fix-reading-auth-settings branch June 26, 2024 18:11
@kevinwcyu kevinwcyu mentioned this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants