Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit hook #242

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Add pre-commit hook #242

merged 3 commits into from
Aug 12, 2024

Conversation

idastambuk
Copy link
Contributor

Adds pre-commit checks:

  • frontend lint with --fix
  • backend lint with --fix
  • spellcheck

with lefthook (https://github.com/evilmartians/lefthook) which we use in main Grafana repo

@idastambuk idastambuk requested a review from a team as a code owner August 2, 2024 09:11
kevinwcyu
kevinwcyu approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@kevinwcyu kevinwcyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@njvrzm njvrzm removed their request for review August 12, 2024 09:10
@idastambuk idastambuk merged commit 0c27238 into main Aug 12, 2024
8 checks passed
@idastambuk idastambuk deleted the lefthook branch August 12, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinwcyu kevinwcyu kevinwcyu approved these changes

@iwysiu iwysiu Awaiting requested review from iwysiu iwysiu is a code owner automatically assigned from grafana/aws-datasources

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@idastambuk @kevinwcyu