Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bra and watch config, update readme #3

Merged
merged 2 commits into from
Jun 8, 2020

Conversation

aocenas
Copy link
Member

@aocenas aocenas commented Jun 5, 2020

Makes for easier dev

@aocenas aocenas requested a review from zoltanbedi June 5, 2020 13:15
Copy link
Member

@zoltanbedi zoltanbedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what is the expectations here but it removes and creates a file for me every sec.

[Bra] 06-05 15:26:52 [ INFO] App Version: 0.4.3.1020
[Bra] 06-05 15:26:52 [ INFO] Following directories are monitored:
-> /home/zbedi/GitHub/plugins/x-ray-datasource
-> $WORKDIR/pkg
-> $WORKDIR/pkg/client
-> $WORKDIR/pkg/configuration
-> $WORKDIR/pkg/datasource
[Bra] 06-05 15:26:52 [DEBUG] Running: mage [-v build:debug]
[Bra] 06-05 15:26:53 [ INFO] "$WORKDIR/mage_output_file.go": CREATE
[Bra] 06-05 15:26:53 [DEBUG] Running: mage [-v build:debug]
Running target: Build:Debug
exec: go build -o dist/gpx_x-ray-datasource_linux_amd64 -tags netgo -gcflags=all=-N -l ./pkg
[Bra] 06-05 15:26:55 [DEBUG] Running: mage [-v reloadPlugin]
[Bra] 06-05 15:26:55 [ INFO] "$WORKDIR/mage_output_file.go": CREATE
[Bra] 06-05 15:26:55 [DEBUG] Running: mage [-v build:debug]
Running target: Build:Debug
exec: go build -o dist/gpx_x-ray-datasource_linux_amd64 -tags netgo -gcflags=all=-N -l ./pkg
[Bra] 06-05 15:26:57 [DEBUG] Running: mage [-v reloadPlugin]
[Bra] 06-05 15:26:58 [ INFO] "$WORKDIR/mage_output_file.go": CREATE
[Bra] 06-05 15:26:58 [DEBUG] Running: mage [-v build:debug]

If that is what we want then it is good for me.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Zoltán Bedi <zoltan.bedi@gmail.com>
@aocenas
Copy link
Member Author

aocenas commented Jun 8, 2020

I'm not sure what is the expectations here but it removes and creates a file for me every sec.

hmm not sure what the issue is it does not do that for me:

andrej@andrej-ubuntu:~/dev/x-ray-datasource$ bra run
[Bra] 06-08 09:58:03 [ INFO] App Version: 0.4.3.1020
[Bra] 06-08 09:58:03 [ INFO] Following directories are monitored:
-> /home/andrej/dev/x-ray-datasource
-> $WORKDIR/pkg
-> $WORKDIR/pkg/datasource
-> $WORKDIR/pkg/configuration
-> $WORKDIR/pkg/client
[Bra] 06-08 09:58:03 [DEBUG] Running: mage [-v build:debug]
[Bra] 06-08 09:58:03 [ INFO] "$WORKDIR/mage_output_file.go": CREATE
[Bra] 06-08 09:58:03 [DEBUG] Running: mage [-v build:debug]
Running target: Build:Debug
exec: go build -o dist/gpx_x-ray-datasource_linux_amd64 -tags netgo -gcflags=all=-N -l ./pkg
[Bra] 06-08 09:58:03 [DEBUG] Running: mage [-v reloadPlugin]
Running target: ReloadPlugin
exec: pgrep -f gpx_x-ray-datasource_linux_amd64
Killing process: 10278
exec: pkill dlv
exec: pgrep -f gpx_x-ray-datasource_linux_amd64
waiting for grafana to start: gpx_x-ray-datasource_linux_amd64...
exec: pgrep -f gpx_x-ray-datasource_linux_amd64
waiting for grafana to start: gpx_x-ray-datasource_linux_amd64...
exec: pgrep -f gpx_x-ray-datasource_linux_amd64
Running PID: 10818
[Bra] 06-08 09:58:04 [ INFO] Notify operations are done!

Can you check what happens if you run those 2 commands which are in bra.toml manually?

@aocenas
Copy link
Member Author

aocenas commented Jun 8, 2020

Or other question, is Grafana running when you start this? If not it is periodically trying to connect to the plugin to restart it. It has different output but worth a try to start grafana to see if anything changes.

@aocenas aocenas merged commit f137a68 into master Jun 8, 2020
@aocenas aocenas deleted the aocenas/add-watch-script-for-backend branch June 8, 2020 08:14
sunker added a commit that referenced this pull request Nov 28, 2022
Add some documentation for cross account queries
sarahzinger added a commit that referenced this pull request Nov 30, 2022
* Filter service graph by account id

* Refactor to create a separate resources route

* Use a map rather than looping everytime

* Fixes after CR:
- refactor /accountIds to /accounts to be more future proof
- make a for loop more readable
- put work behind feature flag
- move call to fetch account ids within QueryEditorForm
- fix bug to reset selection, if account id is no longer a valid option
- fix bug to handle edges with account ids with targets that do not have account ids
- remove accidentally left comments.

* WIP

* More pr fixes and adding in autocomplete

* Fix test

* Fix backend linter

* Fix backend test

* Comment out frontend tests

* Modify plugin.json id

* Fix bug about group name and fix broken test

* Fix go test

* prepare release

* Merge pull request #3 from grafana/lattice-docs

Add some documentation for cross account queries

* Merge main, fix conflicts

* Remove duplicate test from merge conflict

* revert plugin id

Co-authored-by: Sarah Zinger <sarah.zinger@grafana.com>
Co-authored-by: Shirley Leu <4163034+fridgepoet@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants