Add service map support #60
Conversation
src/DataSource.ts
Outdated
| query: serviceQuery, | ||
| }, | ||
| datasourceUid: instanceSettings.uid, | ||
| // @ts-ignore |
There was a problem hiding this comment.
why the need for ts-ignore for this one?
There was a problem hiding this comment.
I just have to update the grafana-data dependency I think we still uses the 7.2 version of those here.
src/utils/transform.ts
Outdated
| type: FieldType.number, | ||
| values: new ArrayVector(), | ||
| labels: { NodeGraphValueType: 'arc' }, | ||
| config: { color: { fixedColor: 'rgb(80, 171, 113)' } }, |
There was a problem hiding this comment.
Is there a way to use named color instead: https://github.com/grafana/grafana/blob/master/packages/grafana-data/src/utils/namedColorsPalette.ts
they adapt slightly a bit for light & dark theme
There was a problem hiding this comment.
Yes I can map it, these are taken directly from x-ray console.
src/DataSource.ts
Outdated
| @@ -41,14 +43,28 @@ export class XrayDataSource extends DataSourceWithBackend<XrayQuery, XrayJsonDat | |||
|
|
|||
| query(request: DataQueryRequest<XrayQuery>): Observable<DataQueryResponse> { | |||
| const processedRequest = processRequest(request, getTemplateSrv()); | |||
| const response = super.query(processedRequest); | |||
| let response; | |||
| if (processedRequest.targets[0].queryType === XrayQueryType.getServiceMapTest) { | |||
There was a problem hiding this comment.
I think we don't need the test with the response anymore right?
src/utils/transform.ts
Outdated
| } | ||
| } | ||
|
|
||
| for (let i = 0; i < edgeTargetField.values.length; i++) {} |
There was a problem hiding this comment.
Yeah does not seem like the most important part of the logic :D
Not all tbh. I tend to sprinkle TODO comments here and there for future reference, like possible refactor, perf improvements etc so usually they are not support important to do right away. Probably makes harder to review and figure out whether it's missed right away or not. Maybe I can use something like TODO(pr) to mark things that should be done before merging the PR. Here I guess |
aocenas
force-pushed
the
aocenas/service-map
branch
from
834c9ef
to
8e12321
Compare
Adds support for service map requests that can be visualized in new Node Graph component (PR: grafana/grafana#29706)