Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong start and end times #89

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Fix wrong start and end times #89

merged 1 commit into from
Oct 21, 2021

Conversation

aocenas
Copy link
Member

@aocenas aocenas commented Oct 15, 2021

Previous PR fixing this was actually wrong #88 as X-Ray sends times as seconds not milliseconds 🤦 .

Copy link
Member

@ivanahuckova ivanahuckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aocenas aocenas merged commit 34849ba into master Oct 21, 2021
@aocenas aocenas deleted the aocenas/fix-times-2 branch October 21, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants