Move JSHandle to js_handle.go

grafana · Oct 10, 2023 · f0c037e · f0c037e
1 parent dd68401
commit f0c037e
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 22 deletions.
diff --git a/common/api.go b/common/api.go
diff --git a/common/js_handle.go b/common/js_handle.go
@@ -9,9 +9,26 @@ import (
 
 	"github.com/chromedp/cdproto/cdp"
 	"github.com/chromedp/cdproto/runtime"
+	cdpruntime "github.com/chromedp/cdproto/runtime"
 	"github.com/dop251/goja"
 )
 
+// JSHandleAPI is the interface of an in-page JS object.
+//
+// TODO: Find a way to move this to a concrete type. It's too difficult to
+// do that right now because of the tests and the way we're using the
+// JSHandleAPI interface.
+type JSHandleAPI interface {
+	AsElement() *ElementHandle
+	Dispose()
+	Evaluate(pageFunc goja.Value, args ...goja.Value) any
+	EvaluateHandle(pageFunc goja.Value, args ...goja.Value) (JSHandleAPI, error)
+	GetProperties() (map[string]JSHandleAPI, error)
+	GetProperty(propertyName string) JSHandleAPI
+	JSONValue() goja.Value
+	ObjectID() cdpruntime.RemoteObjectID
+}
+
 type jsHandle interface {
 	JSHandleAPI
 	dispose() error