Remove Sobek from Execution Context Eval

[ankur22]

What

ExecutionContext.Eval is at the heart of the module. Removing its Goja dependency will tremendously detach goja from most of the business logic. executionContext.eval takes a slice argument, which can be of any type, including goja.Value. Find a way to enforce a change where the slice must be anything BUT a goja.Value.

Why

• Improved stability: Enable avoiding working with the non-thread safe Goja from multiple goroutines.
• Productivity: Business logic can use native Go constructs. Code is simpler and easy to reason about.
• Testability: Testing the business logic becomes straightforward.

How

• Remove goja from Eval and all related methods.
• Ensure that none of the methods in the module passes goja values to Eval and friends.
• Add assertions and keep them there for a few cycles.

Related

#1162

Tasks

Beta Give feedback

1. Remove the call to goja runtime from elementHandle.newPointerAction #1170
   2 of 2
   bug refactor +2
   
2. Remove Goja from Execution Context Eval and from related parts #1189
   async dx refactor tests +4
   
3. Add goja escape assertions #1191
   bug tests +2
   
4. Fix goja escape from DispatchEvents #1193
   bug refactor tests +3
   
5. Move goja runtime usage out of remote_object.go #1168
   3 of 3
   bug +1
   
6. Refactor JSONValue to use parseConsoleRemoteObject #1190
   +0
7. What about the other APIs that still use goja? None of them escape Goja as it seems. (see Move Sobek entirely out of the business logic #1064)
8. Release notes: Add goja refactors in browser module to release notes k6#3578

[inancgumus]

Wrapping up this one 🎉