Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add goja refactors in browser module to release notes #3578

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

ankur22
Copy link
Contributor

@ankur22 ankur22 commented Jan 29, 2024

What?

Add goja refactors in browser module to release notes.

Why?

Keep all users up-to-date with the latest changes.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Updates: grafana/xk6-browser#1162 & grafana/xk6-browser#1182.

@ankur22 ankur22 requested a review from a team as a code owner January 29, 2024 17:39
@ankur22 ankur22 requested review from mstoykov and codebien and removed request for a team January 29, 2024 17:39
@ankur22 ankur22 changed the base branch from master to release-v0.50.0 January 29, 2024 17:39
Copy link
Member

@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

release notes/v0.50.0.md Outdated Show resolved Hide resolved
Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-v0.50.0@cdb1c40). Click here to learn what that means.

❗ Current head 464712f differs from pull request most recent head 77992eb. Consider uploading reports for the commit 77992eb to get more accurate results

Additional details and impacted files
@@                Coverage Diff                 @@
##             release-v0.50.0    #3578   +/-   ##
==================================================
  Coverage                   ?   72.96%           
==================================================
  Files                      ?      280           
  Lines                      ?    20949           
  Branches                   ?        0           
==================================================
  Hits                       ?    15286           
  Misses                     ?     4693           
  Partials                   ?      970           
Flag Coverage Δ
macos 72.89% <0.00%> (?)
ubuntu 72.91% <0.00%> (?)
windows 72.82% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ankur22 ankur22 merged commit 9f65d71 into release-v0.50.0 Jan 30, 2024
23 of 24 checks passed
@ankur22 ankur22 deleted the fix/goja-refactors branch January 30, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants