Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove goja from newPointerAction #1217

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Remove goja from newPointerAction #1217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions common/element_handle.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,21 +399,9 @@ func (h *ElementHandle) offsetPosition(apiCtx context.Context, offset *Position)
return nil, err
}

rt := h.execCtx.vu.Runtime()
var border struct{ Top, Left float64 }
switch result := result.(type) {
case goja.Value:
if result != nil && !goja.IsUndefined(result) && !goja.IsNull(result) {
obj := result.ToObject(rt)
for _, k := range obj.Keys() {
switch k {
case "left":
border.Left = obj.Get(k).ToFloat()
case "top":
border.Top = obj.Get(k).ToFloat()
}
}
}
if err := convert(result, &border); err != nil {
return nil, fmt.Errorf("converting result (%v of type %t) to border: %w", result, result, err)
}

box := h.BoundingBox()
Expand Down
Loading