Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async Page #1355

Merged
merged 48 commits into from
May 30, 2024
Merged

Async Page #1355

merged 48 commits into from
May 30, 2024

Conversation

inancgumus
Copy link
Member

What?

#1307

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

@inancgumus inancgumus added async supports async (promises) breaking PRs that need to be mentioned in the breaking changes section of the release notes mapping k6 browser to Goja mapping related. labels May 28, 2024
@inancgumus inancgumus self-assigned this May 28, 2024
@inancgumus inancgumus requested a review from ankur22 May 28, 2024 12:02
@inancgumus inancgumus marked this pull request as ready for review May 28, 2024 12:02
@inancgumus inancgumus mentioned this pull request May 28, 2024
Closed
@inancgumus inancgumus force-pushed the async/page-prepare-part3 branch from d733e4d to 80bf1cb Compare May 29, 2024 10:01
Base automatically changed from async/page-prepare-part3 to main-async May 29, 2024 10:01
@inancgumus
Add forgetten page err checks in tests
ad9e5b5 
This is happened after rebasing main.
ankur22
ankur22 approved these changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM apart from one API that needs to be double checked.

browser/page_mapping.go Outdated Show resolved Hide resolved
browser/page_mapping.go Show resolved Hide resolved
browser/page_mapping.go Show resolved Hide resolved
ankur22
ankur22 approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@inancgumus inancgumus merged commit a48fc0e into main-async May 30, 2024
14 checks passed
@inancgumus inancgumus deleted the async/page branch May 30, 2024 10:37
@BrewTestBot BrewTestBot mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 approved these changes

Assignees

@inancgumus inancgumus

Labels
async supports async (promises) breaking PRs that need to be mentioned in the breaking changes section of the release notes mapping k6 browser to Goja mapping related.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22