This repository has been archived by the owner on Jan 30, 2025. It is now read-only.
Tiny refactoring for file uploading code #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
previously approved these changes
Sep 11, 2024
inancgumus
force-pushed
the
add/screenshot-upload-v2
branch
from
fcb6d5c to
827263c
Compare
Some small changes to make it more readable (subjectively!) - Move checkStatus utility to bottom to reduce noise while reading - pre-signed to presigned and preSigned to presigned for consistency - getPresignedURL to requestPresignedURL for saying it's a request - newUploadRequest to newFileUploadRequest for specificity - readResponseBody generic naming to specific readPresignedURLResponse - preSignedURLGetterURL to presignedURLRequestURL for consistency
inancgumus
force-pushed
the
refactor/screenshot-uploading
branch
from
63a303b to
b8d6418
Compare
ankur22
approved these changes
Sep 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Improve file persister naming.
Why?
For consistency and readability (hopefully).
Checklist
Related PR(s)/Issue(s)
Updates grafana/k6-cloud#2539