Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove forgotten NewGeolocation #1527

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Remove forgotten NewGeolocation #1527

merged 2 commits into from
Nov 7, 2024

Conversation

inancgumus
Copy link
Member

What?

Remove forgotten NewGeolocation.

Why?

No longer used.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

ankur22
ankur22 previously approved these changes Nov 7, 2024
@inancgumus inancgumus force-pushed the refactor/parse-browser-options branch from e132b27 to 96a3172 Compare November 7, 2024 14:45
@inancgumus inancgumus requested a review from a team as a code owner November 7, 2024 14:45
@inancgumus inancgumus requested review from olegbespalov and joanlopez and removed request for a team November 7, 2024 14:45
Base automatically changed from refactor/parse-browser-options to main November 7, 2024 14:45
@inancgumus inancgumus dismissed ankur22’s stale review November 7, 2024 14:45

The base branch was changed.

The main type here should BrowserContextOptions.
@inancgumus inancgumus force-pushed the remove/newgeolocation branch from 01dcb7f to 182b85d Compare November 7, 2024 14:46
@inancgumus inancgumus merged commit a5ba0c4 into main Nov 7, 2024
6 checks passed
@inancgumus inancgumus deleted the remove/newgeolocation branch November 7, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants