Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Headless from user agent #1536

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Remove Headless from user agent #1536

merged 4 commits into from
Nov 13, 2024

Conversation

inancgumus
Copy link
Member

What?

Sets up Browser.UserAgent to return a user agent without Headless.

Why?

See #1497.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

Updates #1497.

@inancgumus inancgumus self-assigned this Nov 12, 2024
@inancgumus inancgumus requested a review from a team as a code owner November 12, 2024 20:03
@inancgumus inancgumus requested review from ankur22 and joanlopez and removed request for a team November 12, 2024 20:03
@inancgumus inancgumus force-pushed the add/custom-user-agent branch from 8803ebc to 87719e6 Compare November 12, 2024 20:04
@inancgumus inancgumus force-pushed the add/custom-user-agent branch from 87719e6 to 0c4fe3c Compare November 12, 2024 20:14
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@inancgumus inancgumus requested a review from ankur22 November 13, 2024 15:20
@inancgumus inancgumus merged commit 19585e0 into main Nov 13, 2024
23 checks passed
@inancgumus inancgumus deleted the add/custom-user-agent branch November 13, 2024 15:54
@inancgumus inancgumus mentioned this pull request Nov 14, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants