Fix panic in onFrameRequestedNavigation #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This panic is unnecessary since the event is associated to a stale frame that no longer exists in memory.
ankur22
requested review from
oleiade and
olegbespalov
and removed request for
a team
olegbespalov
approved these changes
Nov 25, 2024
oleiade
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Don't return an error from
frameRequestedNavigationwhen aframeis not found (nil).Why?
This panic is unnecessary since the event is associated to a stale frame that no longer exists in memory.
Checklist
Related PR(s)/Issue(s)
Related: #1546