-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breakpoints #1555
Draft
inancgumus
wants to merge
13
commits into
main
Choose a base branch
from
add/debugger-breakpoint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Breakpoints #1555
+480
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage: K6_BROWSER_DEBUG=1 K6_BROWSER_HEADLESS=0 ... Note: Automatically disables headless to work with the DevTools window. Bug: fillform.js loses the DevTools window when it gets redirected to an unauthorized page. It's probably due to the redirect.
inancgumus
force-pushed
the
add/debugger-breakpoint
branch
from
December 2, 2024 15:30
7ec05a7
to
a21dc96
Compare
inancgumus
force-pushed
the
add/debugger-breakpoint
branch
from
December 3, 2024 15:41
59dba6c
to
4cf3ca0
Compare
inancgumus
force-pushed
the
add/debugger-breakpoint
branch
2 times, most recently
from
December 3, 2024 16:09
ef68a20
to
aeb52a5
Compare
inancgumus
force-pushed
the
add/debugger-breakpoint
branch
from
December 3, 2024 16:11
aeb52a5
to
bc4a855
Compare
inancgumus
force-pushed
the
add/debugger-breakpoint
branch
from
December 3, 2024 17:56
01dca21
to
e2b57a3
Compare
inancgumus
force-pushed
the
add/debugger-breakpoint
branch
from
December 3, 2024 19:15
47061d9
to
67731b6
Compare
- We can't ask for the breakpoints, VSCode pushes them when they're available or when the debugger starts. - We need to retrieve the breakpoint details, as well as the column and funcName. These are passed to VSCode when the process is paused. - The sendPause method on the client needs to be called from pause so that VSCode updates the GUI to show where it has paused and to allow for the resume button to be made visible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains experimental features to debug a k6-browser script.
Breakpoint client
This PR adds the ability to pause script execution from the given breakpoints and resume them.
The client pauses the script execution when a breakpoint is hit.
Protocol
get_breakpoints
update_breakpoints
resume
get_breakpoints
The client waits for the server to send an initial set of breakpoints before continuing. The reason for "handshaking" an initial breakpoint is to pause the script execution until the server responds with something. Otherwise, the script would immediately continue.
Client
Server
update_breakpoints
Server
resume
Server
Activate the client
Open a DevTools window
For convenience, users may open a DevTools window.