Remove multierror and refactor to Go errors.Join #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ka3de
reviewed
Apr 11, 2023
@ka3de, that makes sense. But k6 still uses Go 1.19 in |
But this |
inancgumus
force-pushed
the
refactor/738-multierr-to-gomultierr
branch
from
6c25fcb
to
6573e2e
Compare
inancgumus
force-pushed
the
refactor/738-multierr-to-gomultierr
branch
from
6573e2e
to
67b5bef
Compare
inancgumus
added a commit
that referenced
this pull request
Feb 14, 2024
- Linter wasn't working after #850 change. - The previous version is no longer Go 1.19, it's Go 1.21. - Let the actions pick the latest version with 1.x.
3 tasks
inancgumus
added a commit
that referenced
this pull request
Feb 14, 2024
- Linter wasn't working after #850 change. - The previous version is no longer Go 1.19.
inancgumus
added a commit
that referenced
this pull request
Feb 14, 2024
- Linter wasn't working after #850 change. - The previous version is no longer Go 1.19.
inancgumus
added a commit
that referenced
this pull request
Feb 14, 2024
- Linter wasn't working after #850 change. - The previous version is no longer Go 1.19.
inancgumus
added a commit
that referenced
this pull request
Feb 14, 2024
- Linter wasn't working after #850 change. - The previous version is no longer Go 1.19.
inancgumus
added a commit
that referenced
this pull request
Feb 14, 2024
- Linter wasn't working after #850 change. - The previous version is no longer Go 1.19.
inancgumus
added a commit
that referenced
this pull request
Feb 14, 2024
- Linter wasn't working after #850 change. - The previous version is no longer Go 1.19.
inancgumus
added a commit
that referenced
this pull request
Feb 14, 2024
- Linter wasn't working after #850 change. - The previous version is no longer Go 1.19.
inancgumus
added a commit
that referenced
this pull request
Feb 14, 2024
- Linter wasn't working after #850 change. - The previous version is no longer Go 1.19.
inancgumus
added a commit
that referenced
this pull request
Feb 14, 2024
- Linter wasn't working after #850 change. - The previous version is no longer Go 1.19.
inancgumus
changed the base branch from
main
to
bump/github-action-go-versions
inancgumus
added a commit
that referenced
this pull request
Feb 14, 2024
- Linter wasn't working after #850 change. - The previous version is no longer Go 1.19.
inancgumus
force-pushed
the
bump/github-action-go-versions
branch
from
e65a414
to
b517576
Compare
inancgumus
added a commit
that referenced
this pull request
Feb 14, 2024
- Linter wasn't working after #850 change. - The previous version is no longer Go 1.19.
inancgumus
force-pushed
the
refactor/738-multierr-to-gomultierr
branch
from
c5e386f
to
a3c30a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be merged after upgrading Go's previous version on CI (currently 1.19) to 1.20. Currently, the tests fail because of that.
Updates #738.